feat(services/ghac): Allow explicitly setting ghac endpoint/token, not just env vars - #3177
Merged
Conversation
Xuanwo
changed the title
github-actions
Bot
added
the
releases-note/feat
Xuanwo
reviewed
Sep 25, 2023
Xuanwo
left a comment
Xuanwo
left a comment
Member
There was a problem hiding this comment.
Thanks! Mostly LGTM, just need to make our CI happy.
Contributor
Author
|
Oops, fixed. Thanks! |
huonw
pushed a commit
to pantsbuild/pants
that referenced
this pull request
Oct 22, 2023
The pull requests apache/opendal#3163 and apache/opendal#3177 have been merged and included in OpenDAL version 0.41. This PR will update OpenDAL to version 0.41, allowing us to rely on tags rather than a specific GitHub commit. Signed-off-by: GitHub <noreply@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the GitHub Actions Cache service to allow explicitly setting the URL (via
.endpoint(...)) and the runtime token (via.runtime_token(...)), in addition to the defaults of reading theACTIONS_CACHE_URLandACTIONS_RUNTIME_TOKENenvironment variables.This gives more control over the use of this service, such as in the Pants build system (I'm adding support in pantsbuild/pants#19831): for Pants, the caching system runs in a background daemon that is passed some configuration by a client, and it's nice to not have to propagate environment variables into the daemon, instead, it's nicer for the client to read the environment and pass the values as 'normal' configuration.